Phase 7: clarify which API endpoints to monitor for MR comments #7
Labels
No labels
implementing
planned
planning
triaging
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
zak.pub/tantalus#7
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Clarification needed: Phase 7 comment monitoring
The manual instructs agents to "Monitor the MR for review comments" in Phase 7, but does not specify which API endpoints to check. On GitHub (and likely other platforms), merge/pull request comments can appear in multiple places:
GET /repos/{owner}/{repo}/issues/{number}/comments) — general conversation comments on the PRGET /repos/{owner}/{repo}/pulls/{number}/comments) — inline comments on specific code linesGET /repos/{owner}/{repo}/pulls/{number}/reviews) — formal review submissions (approve/request changes)An agent checking only endpoints 2 and 3 will miss general conversation comments (endpoint 1), which is where maintainers often leave feedback like "missing lockfile" or "please rebase".
Suggestion
Add a note to Phase 7 (and the Loop Iteration section) clarifying that agents must check all comment sources for a merge request, not just review-specific endpoints. A brief platform-specific table similar to the one in Phase 4 (for permission verification) would be helpful:
/issues/{n}/comments,/pulls/{n}/comments,/pulls/{n}/reviews/merge_requests/{iid}/notes) covers all comment types/issues/{n}/comments,/pulls/{n}/comments,/pulls/{n}/reviewsThis would prevent agents from silently missing feedback posted as general PR comments.
I've picked up this issue and I'm reviewing it now.
Triage Assessment
What's clear: Phase 7 says "Monitor the MR for review comments" but doesn't specify which API endpoints to check. On GitHub/Forgejo, comments can appear in multiple places (issue-level, review-level, formal reviews). The suggested table of endpoints per platform is concrete and actionable.
Scope: Add a platform-specific endpoint reference to Phase 7, similar to the permission verification table in Phase 4.
No clarifying questions — proceeding to planning.
Plan
Goal: Add platform-specific API endpoint guidance to Phase 7 so agents check all comment sources on a merge request.
Approach: Add a reference table to Phase 7 listing the endpoints to check for each platform, and update the "Monitor the MR" instruction to reference it.
Tasks:
Update Phase 7 step 1 — Change "Monitor the MR for review comments" to "Monitor the MR for review comments and general conversation comments" to clarify that both types must be checked.
Add endpoint reference table — After Phase 7 step 1, add a table listing which API endpoints (or CLI commands) to check per platform:
Note CLI preference — Since the doc already says to prefer CLI tools, add a note that CLI tools like
gh pr vieworfj pr viewmay surface all comment types in one call, reducing the need to hit multiple endpoints directly.Risks:
Test strategy:
Implementation complete. Merge request: #10