Not passing checks #2

Closed
opened 2026-03-19 11:06:34 +00:00 by ReadyPlayerNaN · 4 comments

The flow should react to merge/pull request checks not passing and fix it

The flow should react to merge/pull request checks not passing and fix it
Author
Owner

I've picked up this issue and I'm reviewing it now.

I've picked up this issue and I'm reviewing it now.
Author
Owner

Triage Assessment

What's clear: The document currently has no handling for when CI checks or local verification (pnpm check, pnpm typecheck, tests) fail on the merge request. Phase 7 covers review comments but not check failures. The agent should detect failing checks, investigate, fix, and push.

Scope: Add error handling for failing checks in Phase 7, and potentially a new Error Handling subsection for CI failures.

No clarifying questions — the intent is clear. Proceeding to planning.

## Triage Assessment **What's clear:** The document currently has no handling for when CI checks or local verification (`pnpm check`, `pnpm typecheck`, tests) fail on the merge request. Phase 7 covers review comments but not check failures. The agent should detect failing checks, investigate, fix, and push. **Scope:** Add error handling for failing checks in Phase 7, and potentially a new Error Handling subsection for CI failures. **No clarifying questions** — the intent is clear. Proceeding to planning.
Author
Owner

Plan

Goal: Add error handling for failing CI checks and local verification so the agent knows how to respond when checks don't pass on a merge request.

Approach: Add instructions to Phase 7 for detecting and responding to check failures, and add a new Error Handling subsection for persistent check failures.

Tasks:

  1. Phase 7 — add check failure handling. After the existing review comment handling (step 2), add a step for monitoring CI/check status on the MR. When checks fail:

    • Read the check output / CI logs.
    • Identify the failing check (lint, typecheck, tests, etc.).
    • Fix the issue locally, commit, and push.
    • Re-run local verification (pnpm check, pnpm typecheck, tests) before pushing.
  2. Error Handling — add "Checks Failing" subsection. If checks fail repeatedly and the agent cannot fix them after a reasonable effort:

    • Comment on the MR describing the failure and what was attempted.
    • Comment on the original issue.
    • Follow the existing "Agent Is Stuck" pattern.

Risks:

  • The specific method to read CI logs varies by platform. The doc should state the principle (read logs, fix, push) without prescribing a single API.

Test strategy:

  • Read the updated Phase 7 to verify it covers both review comments and check failures.
  • Verify the new error handling subsection is consistent with existing error handling patterns.
## Plan **Goal:** Add error handling for failing CI checks and local verification so the agent knows how to respond when checks don't pass on a merge request. **Approach:** Add instructions to Phase 7 for detecting and responding to check failures, and add a new Error Handling subsection for persistent check failures. **Tasks:** 1. **Phase 7 — add check failure handling.** After the existing review comment handling (step 2), add a step for monitoring CI/check status on the MR. When checks fail: - Read the check output / CI logs. - Identify the failing check (lint, typecheck, tests, etc.). - Fix the issue locally, commit, and push. - Re-run local verification (`pnpm check`, `pnpm typecheck`, tests) before pushing. 2. **Error Handling — add "Checks Failing" subsection.** If checks fail repeatedly and the agent cannot fix them after a reasonable effort: - Comment on the MR describing the failure and what was attempted. - Comment on the original issue. - Follow the existing "Agent Is Stuck" pattern. **Risks:** - The specific method to read CI logs varies by platform. The doc should state the principle (read logs, fix, push) without prescribing a single API. **Test strategy:** - Read the updated Phase 7 to verify it covers both review comments and check failures. - Verify the new error handling subsection is consistent with existing error handling patterns.
Author
Owner

Implementation complete. Merge request created: #6

Waiting for review.

Implementation complete. Merge request created: https://git.zak.pub/zak.pub/tantalus/pulls/6 Waiting for review.
ReadyPlayerNaN 2026-03-19 11:22:44 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
zak.pub/tantalus#2
No description provided.