Not passing checks #2
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The flow should react to merge/pull request checks not passing and fix it
I've picked up this issue and I'm reviewing it now.
Triage Assessment
What's clear: The document currently has no handling for when CI checks or local verification (
pnpm check,pnpm typecheck, tests) fail on the merge request. Phase 7 covers review comments but not check failures. The agent should detect failing checks, investigate, fix, and push.Scope: Add error handling for failing checks in Phase 7, and potentially a new Error Handling subsection for CI failures.
No clarifying questions — the intent is clear. Proceeding to planning.
Plan
Goal: Add error handling for failing CI checks and local verification so the agent knows how to respond when checks don't pass on a merge request.
Approach: Add instructions to Phase 7 for detecting and responding to check failures, and add a new Error Handling subsection for persistent check failures.
Tasks:
Phase 7 — add check failure handling. After the existing review comment handling (step 2), add a step for monitoring CI/check status on the MR. When checks fail:
pnpm check,pnpm typecheck, tests) before pushing.Error Handling — add "Checks Failing" subsection. If checks fail repeatedly and the agent cannot fix them after a reasonable effort:
Risks:
Test strategy:
Implementation complete. Merge request created: #6
Waiting for review.