zak.pub/tantalus

Fork 0

Loop Iteration and Phase 7: add instruction to check CI status #8

New issue

Closed

opened 2026-03-19 11:28:26 +00:00 by ReadyPlayerNaN · 4 comments

ReadyPlayerNaN commented

2026-03-19 11:28:26 +00:00

Owner

Problem

The Loop Iteration section and Phase 7 actions instruct the agent to monitor the MR for review comments, but do not mention checking CI/check status. The Phase 8 gate requires "CI passes," but by that point the agent has no prior instruction to have been monitoring CI.

This caused a real issue: my PR had failing CI checks (docs build broken by a new dependency), but I kept reporting "noop" on loop iterations because I was only checking for comments and reviews — not CI status.

Where CI checks should be mentioned

Loop Iteration step 1 — In addition to checking for comments and reactions, the agent should check CI status for any issue in Phase 7.
Phase 7 actions — Add an action item: "Check CI status on the MR. If checks are failing, investigate and fix before waiting for reviewer feedback."
Phase 7 gate — Already mentions "CI passes" but this is too late if the agent never looked.

Suggestion

Add to Loop Iteration step 1:

Phase 7: check for review comments on the merge request and CI/check status.

Add to Phase 7 actions (after item 1):

1b. Check CI status on the MR. If checks are failing, investigate the failure logs, fix the issue, commit, and push. Do not wait for reviewer feedback on code that doesn't build.

This aligns with the existing principle of "finish before starting" — a failing CI is an actionable item the agent can resolve without waiting.

## Problem The Loop Iteration section and Phase 7 actions instruct the agent to monitor the MR for **review comments**, but do not mention checking **CI/check status**. The Phase 8 gate requires "CI passes," but by that point the agent has no prior instruction to have been monitoring CI. This caused a real issue: my PR had failing CI checks (docs build broken by a new dependency), but I kept reporting "noop" on loop iterations because I was only checking for comments and reviews — not CI status. ### Where CI checks should be mentioned 1. **Loop Iteration step 1** — In addition to checking for comments and reactions, the agent should check CI status for any issue in Phase 7. 2. **Phase 7 actions** — Add an action item: "Check CI status on the MR. If checks are failing, investigate and fix before waiting for reviewer feedback." 3. **Phase 7 gate** — Already mentions "CI passes" but this is too late if the agent never looked. ### Suggestion Add to Loop Iteration step 1: > - Phase 7: check for review comments on the merge request **and CI/check status**. Add to Phase 7 actions (after item 1): > 1b. Check CI status on the MR. If checks are failing, investigate the failure logs, fix the issue, commit, and push. Do not wait for reviewer feedback on code that doesn't build. This aligns with the existing principle of "finish before starting" — a failing CI is an actionable item the agent can resolve without waiting.

ReadyPlayerNaN self-assigned this

2026-03-19 11:30:54 +00:00

ReadyPlayerNaN added the

triaging

label

2026-03-19 11:30:59 +00:00

ReadyPlayerNaN commented

2026-03-19 11:31:05 +00:00

Author

Owner

I've picked up this issue and I'm reviewing it now.

ReadyPlayerNaN commented

2026-03-19 11:31:31 +00:00

Author

Owner

Triage Assessment

What's clear: The Loop Iteration section (line 41) says "check for review comments on the merge request" for Phase 7 but doesn't mention CI/check status. Phase 7 step 3 already handles CI failures (added by #2), but the Loop Iteration summary is out of sync.

Scope: Update the Loop Iteration section to mention CI status for Phase 7 issues. Phase 7 actions themselves already cover CI monitoring.

No clarifying questions — proceeding to planning.

## Triage Assessment **What's clear:** The Loop Iteration section (line 41) says "check for review comments on the merge request" for Phase 7 but doesn't mention CI/check status. Phase 7 step 3 already handles CI failures (added by #2), but the Loop Iteration summary is out of sync. **Scope:** Update the Loop Iteration section to mention CI status for Phase 7 issues. Phase 7 actions themselves already cover CI monitoring. **No clarifying questions** — proceeding to planning.

ReadyPlayerNaN added

planning

and removed

triaging

labels

2026-03-19 11:31:39 +00:00

ReadyPlayerNaN commented

2026-03-19 11:32:01 +00:00

Author

Owner

Plan

Goal: Update the Loop Iteration section to include CI/check status monitoring for Phase 7 issues, aligning it with the existing Phase 7 actions.

Approach: Edit the Loop Iteration section to mention CI status alongside review comments for Phase 7.

Tasks:

Update Loop Iteration step 1, Phase 7 bullet — Change "Phase 7: check for review comments on the merge request" to "Phase 7: check for review comments on the merge request and CI/check status. If checks are failing, treat them as actionable before waiting for reviewer feedback."

Risks:

None — this is a one-line change that aligns the summary with the already-existing Phase 7 step 3.

Test strategy:

Verify the Loop Iteration section now mentions CI for Phase 7.
Verify consistency with Phase 7 step 3 (already covers CI failure handling).

## Plan **Goal:** Update the Loop Iteration section to include CI/check status monitoring for Phase 7 issues, aligning it with the existing Phase 7 actions. **Approach:** Edit the Loop Iteration section to mention CI status alongside review comments for Phase 7. **Tasks:** 1. **Update Loop Iteration step 1, Phase 7 bullet** — Change "Phase 7: check for review comments on the merge request" to "Phase 7: check for review comments on the merge request and CI/check status. If checks are failing, treat them as actionable before waiting for reviewer feedback." **Risks:** - None — this is a one-line change that aligns the summary with the already-existing Phase 7 step 3. **Test strategy:** - Verify the Loop Iteration section now mentions CI for Phase 7. - Verify consistency with Phase 7 step 3 (already covers CI failure handling).

👍 1

ReadyPlayerNaN added

implementing

and removed

planning

labels

2026-03-19 11:32:07 +00:00

ReadyPlayerNaN referenced this issue from a commit

2026-03-19 11:50:53 +00:00

docs: add CI status check to Loop Iteration for Phase 7

ReadyPlayerNaN referenced this issue from a pull request that will close it,

2026-03-19 11:51:00 +00:00